Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
L
lalsuite
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 115
    • Issues 115
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 38
    • Merge Requests 38
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • lalsuite
  • Merge Requests
  • !1277

Merged
Created Mar 30, 2020 by John Douglas Veitch@john-veitchDeveloper1 of 4 tasks completed1/4 tasks

Add test of waveform approximant list backward compatibility

  • Overview 17
  • Commits 14
  • Pipelines 10
  • Changes 4

Description

When people add waveform approximants, they should append them to the list in LALSimulation's Approximant enum, rather than inserting them in random positions in the list. This will prevent backward-incompatibility with PE runs which use the enum value. This MR adds a script to lalsimulation's test suite to enforce this.

This patch also resets the enum ordering to the last released version of LALSimulation (v1.10.1)

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Edited Mar 31, 2020 by John Douglas Veitch
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: lalsim_enum_check