Skip to content

Add test of waveform approximant list backward compatibility

John Veitch requested to merge john-veitch/lalsuite:lalsim_enum_check into master

Description

When people add waveform approximants, they should append them to the list in LALSimulation's Approximant enum, rather than inserting them in random positions in the list. This will prevent backward-incompatibility with PE runs which use the enum value. This MR adds a script to lalsimulation's test suite to enforce this.

This patch also resets the enum ordering to the last released version of LALSimulation (v1.10.1)

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Edited by Ghost User

Merge request reports