Skip to content

MakeSFTs.c: fix sprintf size bug

David Keitel requested to merge david-keitel/lalsuite:makesfts-mvFilenames-length-fix into master

Description

This is a tiny patch extracted from the changes suggested by external contributor Reinhard Prix in #275 (closed) to fix a warning/error thrown by his gcc 8.3 compiler. (Weirdly, with my own gcc (Debian 8.3.0-6) 8.3.0, which I think is the same OS version as Reinhard too, I don't see this, but the patch looks correct, see below.)

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@karl-wette Patch looks correct to me, as the two input strings are 256 long each (see https://git.ligo.org/lscsoft/lalsuite/-/blob/master/lalapps/src/pulsar/MakeSFTs/MakeSFTs.c#L1895 ) and 4 extra characters are added in the commandline.

Edited by Ghost User

Merge request reports