Skip to content

DetResponseTest.c: fix strncpy length

David Keitel requested to merge david-keitel/lalsuite:DetResponseTest-strncpy-fix into master

Description

This is a tiny patch extracted from the changes suggested by external contributor Reinhard Prix in #275 (closed) to fix a warning/error thrown by his gcc 8.3 compiler. (Weirdly, with my own gcc (Debian 8.3.0-6) 8.3.0, which I think is the same OS version as Reinhard too, I don't see this, but the patch looks correct, see below.)

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

I couldn't reproduce the initial compiler complaint, but the suggested fix matches what quick Googling seems to suggest is the correct strncpy() usage. Let's see who can approve this, they can triple-verify the fix then.

Merge request reports