Skip to content

XLALCWMakeFakeData(): check TS alignment and ensure transient signals are aligned

David Keitel requested to merge david-keitel/lalsuite:CWMakeFakeData-transient-signals-timeshift into master

Description

Last one of the commits suggested by Reinhard Prix in #275 (closed). I think this solves the problem on the (t)CW side independently from !1289 (closed), but I didn't get around to producing a specific test case yet. Posting for comments from @karl-wette already; specifically, as in !1289 (closed) I also wonder here whether we should be more careful about the end time / TS duration as well.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Looks sane; test will be added.

Edited by Ghost User

Merge request reports