Skip to content

lalapps_splitSFTs: fix error message and initialization of --minStartTime --maxStartTime

David Keitel requested to merge david-keitel/lalsuite:fix-splitSFTs-minmaxtime-check into master

Description

This is a fixup to !1269 (merged) to fix the MacOS pipeline failure in #294 (closed) which actually uncovered a beginner's coding mistake I had made and that magically did not cause problems on Linux.

The main fix is to move a variable definition outside of an if block, so a pointer to it becomes safe.

The larger diff further down the file is just to provide a proper error message with the right constraint (or lack thereof) for the various possible combinations.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

This has been tested by @pep.covas on a MacBook. @karl-wette please double-check.

Merge request reports