Skip to content

PulsarDataTypes: change PulsarParams::name to a fixed-length array

Karl Wette requested to merge (removed):PulsarParams-fixed-length-name into master

Description

Changes the name field of the PulsarParams struct (in the LALPulsar PulsarDataTypes.h header) from a dynamic to a fixed-length string. This makes usage from SWIG easier since it avoids memory ownership issues. Fixes an issue reported by Reinhard.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Changes the name field from char * to char [LALNameLength]. It's unlikely any significant code outside of LALSuite relies on the old API.

Review Status

Various tests set the name field so should test for correctness.

Merge request reports