Skip to content

lalburst.snglcoinc: python3 fixes

Patrick Godwin requested to merge patrick.godwin/lalsuite:lalburst_python3 into master

Description

This merge request fixes a few issues encountered within snglcoinc.py for python3, namely:

  • singlesqueue: Cast the result of map to a list for consistent behavior between python 2 and 3. I ran into this issue where trying to sort self.incomplete after a map was problematic, since map returns a generator instead of a list in python3.
  • multidict: A call to multidict.iteritems() crashed since it was using dict.iteritems(). I have also defined a multidict.items() which has identical behavior to multidict.iteritems() to mimic a dict, but if that is problematic I'm happy to remove this. That is the extent to the "new API calls".

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Edited by LALSuite Bot

Merge request reports