SynthesizeCWDraws: revert to consistent (h0,cosi) output in --outputInjParams

Description

This fixes a small issue introduced last year by !482 (merged) which I only just noticed: for the SynthesizeCWDraws module and the three lalapps codes calling it, the internal conversion (h0,cosi)<->(Aplus,Across) is fine as far as I can tell, but the file output should have been left as (h0,cosi) for backwards compatibility and since this was still what the columns header string said. It's also still the more natural output tuple here since the input arguments for the lalapps codes are all --h0 --cosi only, anyway.

API Changes and Justification

Backwards Compatible Changes

• This change introduces no API changes
• This change adds new API calls

Backwards Incompatible Changes

• This change modifies an existing API
• This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Small fix for @karl-wette to review. For the record, it's unlikely that this would have been caught by a test script, since its a header-content mismatch in a secondary output file which is usually only looked at for debugging.

lalpulsar/lib/SynthesizeCWDraws.c

@@ -769,11 +769,23 @@ write_InjParams_to_fp ( FILE * fp,			/**< [in] file-pointer to output file */
     }
   }
 
+  /* since the user inputs for codes using this module are typically in (h0,cosi),
+   * write out parameters in the same variables
+   */
+  REAL8 h0, cosi;
+  h0 = par->ampParams.aPlus + sqrt( SQ(par->ampParams.aPlus) - SQ(par->ampParams.aCross) );
+  if (h0 > 0) {
+    cosi = par->ampParams.aCross/h0;
+  }
+  else {
+    cosi = 0;
+  }
+
   /* if injParams given, output them to the file */
   ret = fprintf ( fp, " %5.3f %6.3f   %6.3f  %7.3g %6.3f %6.3f %6.3f % 9.3g % 9.3g % 9.3g % 9.3g %10.5g %10.5g %10.5g %10.5g    %9.3f  %9.3f    %1d %9.3g%s\n",
                   par->skypos.longitude, par->skypos.latitude,						/* skypos */
                   par->SNR,										/* SNR */
-                  par->ampParams.aPlus, par->ampParams.aCross, par->ampParams.psi, par->ampParams.phi0,	/* amplitude params {aPlus,aCross,psi,phi0}*/
+                  h0, cosi, par->ampParams.psi, par->ampParams.phi0,	/* amplitude params {h0,cosi,psi,phi0} */
                   par->ampVect[0], par->ampVect[1], par->ampVect[2], par->ampVect[3],			/* ampltiude vector A^mu */
                   par->multiAM.Mmunu.Ad, par->multiAM.Mmunu.Bd, par->multiAM.Mmunu.Cd, par->multiAM.Mmunu.Dd,	/* antenna-pattern matrix components */
                   t0_d, tau_d, par->transientWindow.type,		/* transient-window params */