Skip to content

Set uvar defaults of Fstat lalapps codes from FstatOptionalArgsDefaults

David Keitel requested to merge david-keitel/lalsuite:CFS-defaults into master

Description

As discussed in https://git.ligo.org/CW/software/lalsuite/-/issues/83 this changes the user variable defaults for lalapps_ComputeFstatistic_v2 and some other pulsar codes to use the global lalpulsar defaults set in FstatOptionalArgsDefaults. Not all of the codes support the same options, but in general I've chosen to change runningMedianWindow, SSBprec, Dterms, FstatMethod and resampFFTPowerOf2 where appropriate. The other members of FstatOptionalArgsDefaults aren't really "choices" in the sense that it makes sense to default to them.

(Weave seems to already be using the central defaults.)

For lalapps_ComputeFstatistic_v2 itself the biggest change is in switching the default runningMedianWindow from the old 50 to the more usual 101. I've adapted testComputeFstatistic_v2_grids.sh to keep doing 50 so the reference results wouldn't need to be updated.

Closes https://git.ligo.org/CW/software/lalsuite/-/issues/83

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@karl-wette please have a look.

Edited by Ghost User

Merge request reports