Skip to content

Allow glitch and timing noise pulsar phase evolution as inputs to HeterodynedPulsarGetModel

Matthew Pitkin requested to merge matthew-pitkin/lalsuite:fitwaves into master

Description

The model of a pulsar's phase evolution can include components that model pulsar glitches and also that model timing noise (FITWAVES parameters in TEMPO2). These can be precomputed and then added together to get the full pahse evolution. This is currently done in the lalapps pulsar model (ppe_model.c in lalapps/src/pulsar/HeterodynedSearch), but was not included in the version ported into lalpulsar. This MR updates the HeterodynedPulsarGetModel function to allow these components to be passed to it. It also updates the equivalent Python API for the producing the simulated signals.

These functions are currently not use in any production code, so changes to the API do not affect any search code. I will be adding some tests of these to show that they work correctly.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

No production code yet uses these functions, so the API changes will not affect any search codes.

Review Status

cc @karl-wette @david-keitel - I'll have some tests to add to this MR soon.

Edited by Ghost User

Merge request reports