Skip to content

Exit gracefully when surrogate data is missing

Vijay Varma requested to merge waveforms/reviews/lalsuite:SurrogateDataNotFoundFix into master

Description

The code used to segfault before when surrogate data was missing in $LAL_DATA_PATH, see Issue #291 (closed).
This is now fixed for NRSur7dq4, NRSur7dq4Remnant and NRSur3dq8Remnant.
The only change is an extra sanity check, so the waveform/remnant output is not changed in any way.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

These models have already been reviewed:
https://git.ligo.org/waveforms/reviews/nrsur7dq4.
https://git.ligo.org/waveforms/reviews/RemnantFits.

Merge request reports