Skip to content

CFSv2: deprecate old --IFO option

David Keitel requested to merge david-keitel/lalsuite:cfsv2-remove-old-ifo-option into master

Description

Deprecates an ancient option to lalapps_ComputeFStatistic_v2 as discussed in #318 (closed). Will remove in a future MR after the current release cycle.

First commit just cleans up indentation in a test script in preparation for the next one.

Second commit does the minimal changes required to local test scripts so they won't fail later when the option gets removed. There may still be other instances in other parts of lalapps/src/pulsar since some other codes are tested against CFSv2 and it's hard to search for an option name that occurs a lot more often for the MFD codes, but those can be fixed with the removal MR later on. For now I just needed to be sure that typical remaining use cases are indeed trivial to replace.

Third commit is the deprecation and help string update in the executable.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

(Here I'm guessing that deprecation doesn't count as an actual change yet.)

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@karl-wette The most non-trivial test script change was the removal of a MFDv4 option --outSFTv1 in the grids test, no idea why that was still there.

Edited by Ghost User

Merge request reports