Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
L
lalsuite
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 113
    • Issues 113
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 33
    • Merge Requests 33
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • lalsuite
  • Merge Requests
  • !1368

Merged
Created Jun 26, 2020 by David Keitel@david-keitelDeveloper1 of 4 tasks completed1/4 tasks

change test_phenomX.py to relative tolerances

  • Overview 16
  • Commits 1
  • Changes 1

Description

In order to fix #338 (closed): change test_phenomX.py to relative tolerances

 -switch from assert_almost_equal() to assert_allclose()
 -XPHM-no32 tolerance was tuned to fix
  https://git.ligo.org/lscsoft/lalsuite/-/issues/338
 -other tolerances work on Debian, amd64, gcc 8.3.0
  but may require further adjustment for other systems

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@maria.haney for nominal sign-off, though we'll of course want to see what the pipelines say it would be good to also hear from @alexander.pace and @steffen.grunewald and anyone else running non-standard before merging.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix-test_IMRPhenomXPHM