Skip to content

GitLab

Merged
Created by David Keitel@david-keitelDeveloper1 of 4 tasks completed1/4 tasks

change test_phenomX.py to relative tolerances

Description

In order to fix #338 (closed): change test_phenomX.py to relative tolerances

 -switch from assert_almost_equal() to assert_allclose()
 -XPHM-no32 tolerance was tuned to fix
  https://git.ligo.org/lscsoft/lalsuite/-/issues/338
 -other tolerances work on Debian, amd64, gcc 8.3.0
  but may require further adjustment for other systems

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@maria.haney for nominal sign-off, though we'll of course want to see what the pipelines say it would be good to also hear from @alexander.pace and @steffen.grunewald and anyone else running non-standard before merging.