Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
L
lalsuite
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 115
    • Issues 115
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 38
    • Merge Requests 38
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • lalsuite
  • Merge Requests
  • !1371

Merged
Created Jun 29, 2020 by Vijay Varma@vijay.varmaContributor1 of 4 tasks completed1/4 tasks

Revert "Disable PN spin evolution" for NRSur7dq4Remnant

  • Overview 2
  • Commits 2
  • Changes 2

Description

Turn PN spin evolution back on for NRSur7dq4Remnant fits. It was temporarily disabled to investigate potential nonsmooth behavior but this is now resolved.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

The basic code has already been reviewed, but this change still needs to be signed-off: https://git.ligo.org/waveforms/reviews/RemnantFits/-/wikis/home

Edited Jul 10, 2020 by Vijay Varma
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: RemnantFits-review