Skip to content

lalapps_dumpSFT updates

David Keitel requested to merge david-keitel/lalsuite:lalapps_dumpSFT-updates into master

Description

@karl-wette Two changes to lalapps_dumpSFT so far, one more suggested subject to API requirements:

  • remove deprecated --noHeader option
  • add --Nmax (-N) option to only dump the N first SFTs and exit early when pattern/catalog contains >N individual SFTs (compatible with all 3 dump modes, test script extended to match) -- this would have often saved me some complicated wc/head maneuvers
  • I'd like to move the XLALprintDescriptor, XLALprintHeader, XLALprintData, XLALprintTimestamps functions to lalpulsar, either SFTfileIO.c or SFTutils.c (with suitably amended names). a) do I understand correctly that adding new functions to the library is still fine, b) which target file would be more appropriate? dropped after discussion

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Edited by Ghost User

Merge request reports