Fix dimension freq series PhenomHM(Pv3HM)XHM

Description

This fixes the issue #346 (closed), which extends also for IMRPhenomHM and IMRPhenomXHM.

API Changes and Justification

Backwards Compatible Changes

• This change introduces no API changes
• This change adds new API calls

Backwards Incompatible Changes

• This change modifies an existing API
• This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

This was only reviewed by Cecilio at the moment

mentioned in issue #346 (closed)

Tagging @sebastian-khan @maria.haney

added lalsimulation + 1 deleted label

added 2 commits

• 1a64ed46 - Fix units single-mode functions with multibanding
• 50d366c3 - Correct epoch for negative freq array for XPHMOneMode function

Compare with previous version

I saw that some single mode functions in XHM had also the problem of the units and corrected it.

Also, related to the epoch issue #343 (closed), I fixed the epoch time for the array of negative frequencies that is returned by IMRPhenomXPHMOneMode

assigned to @maria.haney and @sebastian-khan

I'm not familiar with the usual conventions, but sounds good to me.

@maria.haney could you review/approve this, and if it's good to merge, then we request a release with this and !1375 (merged)?

@cecilio.garcia-quiros @david-keitel Happy to sign off on the X(P)HM changes. Can you document this fix on the review page (with the buggy/fixed output and reference to the git issue and this MR), maybe under a separate heading "Post-review fixes" at the very end of the main wiki?

There shouldn't be any issues with the modifications of Pv3HM source code either, but I'll let @sebastian-khan have the last word on this.

resolved all threads

Hi Folks, @harald.pfeiffer pointed me to this issue as it concerns the PE runs for the GW200105/GW200115 paper. I'm unfamiliar with the details of the waveforms so I'd like to check if this issue will be a problem for PE (i.e., do we have to rerun) or is it minor enough that it shouldn't matter?

Getting @cjhaster into the loop, who might know the answer whether this matters for PE.

added 48 commits

• 50d366c3...a8948d21 - 47 commits from branch lscsoft:master
• 6c460e3b - Merge remote-tracking branch 'upstream/master' into fix-dimension-freqseries-Phenom

Compare with previous version

resolved all threads

adding approval

approved this merge request

merged

mentioned in commit afe28770

mentioned in issue #350 (closed)

mentioned in commit adam-mercer/lalsuite@28e72f63

mentioned in commit adam-mercer/lalsuite@c0dda25a