Skip to content

WIP: Fscan/spec_avg_long: remove copy-and-paste of SFT file I/O code

Karl Wette requested to merge (removed):Fscan-remove-copy-paste-SFT-IO-code into master

Description

Fscan/spec_avg_long.c includes a large copy-and-paste of SFT file I/O code from SFTfileIO.c. As far as I can tell, the only reason this is done is so that spec_avg_long can load a single SFT from a catalog at a time. However this is easily done by creating a dummy catalog containing the SFTDescriptor for a single SFT at a time; this change is made in the 1st commit. The 2nd commit removes the duplicated SFT file I/O code.

Since this code doesn't have a test suite, I've no way of testing that this hasn't broken anything.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@david-keitel

Edited by Karl Wette

Merge request reports