Skip to content

Return seobnrv3 dynamics properly

Prayush Kumar requested to merge prayush-kumar/lalsuite:fix_dynamics_output_seobnrv3 into master

Description

This minor change makes the dynamics being output by SEOBNRv3 more useful. It makes no change to the model OR to any quantity being calculated for the model, only to its auxiliary output.

The inspiral portion for SEOBNRv3 is evolved at the user-requested sample rate. Very close to merger, a much higher sample rate is used in order to enable precise attachment of the ringdown portion. The dynamics being output currently is the one evolved at high sampling rate, which only corresponds to a tiny fraction of the CBC process.

This merge request changes that to the dynamics from the full inspiral, thereby making the output more useful.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

Note: This change makes no change to the model OR to any quantity being calculated for the model, only to its auxiliary output.

Merge request reports