CFSv2: remove deprecated options
Description
As discussed in #337 (closed) this removes deprecated and defunct options from CFSv2. Except for --IFO
which has only technnically been deprecated before the last release in !1361 (merged) (but has been useless for a decade or so, since it was only relevant for an outdated file format), all other options have been deprecated/defunct for a long time and replacements are available where necessary:
-
--outputLogPrintf
,--internalRefTime
,--dopplermax
-> long defunct -
--RA
,--Dec
-> just use--Alpha
,--Delta
instead - transient options with
Days
as unit -> just use the more robust standard options in seconds -
--SignalOnly
-> this is the only one giving me trouble and causing theWIP:
@karl-wette from the source code comments, I would have assumed --SignalOnly
can be replaced safely by --assumeSqrtSX=1
on fake SFTs with no noise. However, if I do that in testComputeFstatistic_v2_grids.sh
it fails the comparison of grid2 against the reference results, as the explicit +4 offset correction in 2F is now missing. I know Reinhard and you discussed this at length in the past, so what would be the correct fix?
API Changes and Justification
Backwards Compatible Changes
-
This change introduces no API changes -
This change adds new API calls
Backwards Incompatible Changes
-
This change modifies an existing API -
This change removes an existing API
If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.
Review Status
For Karl.