Skip to content

check_waveform_macros.h: replace ABORT...() macros with XLAL_ERROR() calls

Karl Wette requested to merge (removed):remove-abort-macros into master

Description

  • Functions should not destroy input arguments on error; implied LALSuite memory model is that function arguments belong to the caller. SWIG wrappings rely on this memory model, and will break if this is violated
  • Since, without the destructors, these macros just raise an XLAL error, replace them with direct calls to XLAL_ERROR()
  • Fixes #308 (closed), #357 (closed)

See discussion on #308 (closed) for further info.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

N/A

Merge request reports