Skip to content

Allow a custom value of max ell for the Nyquist check for SEOBNRv4P(HM)

Serguei Ossokine requested to merge serguei.ossokine/lalsuite:nyquist_flag into master

Description

This merge request allows a custom value of ell to be used for the Nyquist check of the sampling rate, i.e that the sampling rate is high enough to resolve the particular ell mode in the ringdown. The default is such that for SEOBNRv4P ell=2 and for SEOBNRv4PHM it is 5. The code will also return an error if one passes a value of ell<2. If the custom value of ell is less than the default (possible for SEOBNRv4PHM) a warning is printed for the user.

Also fixes a possible segfault in the function used for the ChooseTDModes interface, in the case when the sampling rate is too low.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

This is a change to the reviewed SEOBNRv4P/SEOBNRv4PHM models

Edited by Serguei Ossokine

Merge request reports