Skip to content

NRSur7dq4: Fix memory leak when fMin is too low

Vijay Varma requested to merge vijay.varma/lalsuite:NRSur7dq4FixMemoryLeak into master

Description

This resolves a memory leak in the NRSur7dq4 model that occurs when fMin is outside the validity range of the model.
No changes to the actual waveform output.

This was reported in #354 (closed), and was thought to be resolved in !1404 (merged), but there was a lingering issue (see https://git.ligo.org/sccb/requests/-/issues/575#note_205987), which is fixed now.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

This model has already been reviewed: https://git.ligo.org/waveforms/reviews/nrsur7dq4/-/wikis/home

Merge request reports