Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
L
lalsuite
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 105
    • Issues 105
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 26
    • Merge Requests 26
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • lscsoft
  • lalsuite
  • Merge Requests
  • !1453

Merged
Opened Oct 29, 2020 by Kipp Cannon@kipp.cannonDeveloper1 of 4 tasks completed1/4 tasks

Two ligolw updates

  • Overview 0
  • Commits 2
  • Pipelines 1
  • Changes 3

Description

Remembered two issues that should be addressed now that lalsuite has transitioned to integer IDs in XML files.

  • There are two places where the append_process() function from glue.ligolw.utils.process is used. This function does not exist in ligo.lw, and the first patch updates the affected codes. I don't believe they are used by any production analyses, so I don't think there is a need to get this fix into an updated release on a short time scale. I know ligolw_bucut is not required by the string search, I can't find anything that uses inspiralutils.py at all. The latter might be suitable for deletion, but this patch just fixes it.

  • Since ligo.lw is now a required dependency, cache.py no longer requires a fall-back option to glue. removing the fall-back reduces by one line the number of inter-package dependency links.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Not reviewed.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: lscsoft/lalsuite!1453
Source branch: two_ligolw_updates

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.