Skip to content

Two ligolw updates

Kipp Cannon requested to merge (removed):two_ligolw_updates into master

Description

Remembered two issues that should be addressed now that lalsuite has transitioned to integer IDs in XML files.

  • There are two places where the append_process() function from glue.ligolw.utils.process is used. This function does not exist in ligo.lw, and the first patch updates the affected codes. I don't believe they are used by any production analyses, so I don't think there is a need to get this fix into an updated release on a short time scale. I know ligolw_bucut is not required by the string search, I can't find anything that uses inspiralutils.py at all. The latter might be suitable for deletion, but this patch just fixes it.

  • Since ligo.lw is now a required dependency, cache.py no longer requires a fall-back option to glue. removing the fall-back reduces by one line the number of inter-package dependency links.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Not reviewed.

Merge request reports