pSEOBNRv4HM test of GR branch

Description

This is a pipeline to do a test of GR using gravitational wave signals from binary black hole systems, where we treat the (complex) QNM frequencies as free parameters and estimate them directly from the data. The code involves changes to the SEOBNRv4HM model, where the QNM parameters are sampled over as non-GR parameters, in addition to the GR parameters. It also introduces changes to the parameter estimation code to recognise those free parameters, sample over them and plot them. We further make changes to the injection infrastructure to allow us to simulate signals with free QNM parameters.

API Changes and Justification

Backwards Compatible Changes

• This change introduces no API changes
• This change adds new API calls

Backwards Incompatible Changes

• This change modifies an existing API
• This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

This pipeline has been reviewed and used to produce results for the pSEOBNRv4HM ringdown test of GR that has gone into the O3a TGR paper. The review wiki is here: https://git.ligo.org/cbc-testinggr/reviews/nohairtesteobhm/-/wikis/home

and specifically, the code review page is here: https://git.ligo.org/cbc-testinggr/reviews/nohairtesteobhm/-/wikis/Code-review_v4

added lalapps lalinference lalinspiral lalmetaio lalsimulation lang_python + 1 deleted label

added 1211 commits

• fef99971...1016f628 - 1203 commits from branch lscsoft:master
• ae6684ad - ported changes from remote branch pSEOBNRv4HM to the SEOBNRv4HM
• 1049c8f8 - Introduced dtauinv as a fractional deviation in the denominator of
• 81946ed2 - changes variable names from tauinv to tau
• 9b07f8b1 - added changes in lalsimulation/src/LALSimInspiralWaveformCache.c
• 2bf77a0a - modifications to make termination condition for ringdown dependent on dtau
• 1e8dfc8d - modifications to array size to avoid problems when dtau<0
• fc082eb5 - updated injection structure
• d16da559 - updated right way to inject deviations

Compare with previous version

added 1 commit

• bb440119 - added lines inadvertantly removed from LALSimInspiralWaveformParams.h while rebasing

Compare with previous version

added 1 commit

• d4f3326f - added the TGR parameters to SEOBNRv4PHM vs 4HM ringdown test: now passes test

Compare with previous version

added 1 commit

• 7c184e36 - removed a stray } in bayespputils.py

Compare with previous version

Hi @jolien-creighton, I am trying to merge my reviewed ringdown branch to master. My branch is failing some of the lalinspiral build tests, and I am not sure how to get round them. I am writing to you as you were listed as the lalinspiral reviewer. Could you help me with this? Thanks in advance.

At a glance it looks like this might have been a blip with the CI... @adam-mercer could you see if this needs to be nudged?

The jobs are rerunning

added 1 commit

• 730f5321 - added documentation about QNM parameters to LALSimIMREOBHybridRingdown.c and...

Compare with previous version

The rerun lalinspiral jobs might have failed as well. As well as the integration tests. However, the documentation tests now seem to have passed.

Looks like an actual problem, not sure why it passes on Debian but not on EL7 or Conda...

@abhirup.ghosh the problem could be related to this:

FAIL: InjectionInterfaceTest
============================
unable to find column domega220
Error[1] 1: function LALFindChirpInjectSignals, file FindChirpSimulation.c, line 136, $Id$
        Assertion "events" failed: Null pointer
Error[0] 1: program $SRC_DIR/test/.libs/lt-InjectionInterfaceTest, file InjectionInterfaceTest.c, line 228, $Id$
        Function call "LALFindChirpInjectSignals( &status, &ts, injections, &fs )" failed: Subroutine failed
FAIL InjectionInterfaceTest (exit status: 1)

added 1 commit

• 58db379d - added the additional columns of domega220 and dtau220 into test injection.xml

Compare with previous version

added 1 commit

• 236672bd - fixed a missing comma

Compare with previous version

Hi @jolien-creighton, @adam-mercer, I have now fixed the remaining issue. And the pipeline build passes.