Skip to content

Fix --modesList argument GenerateSimulation

Cecilio Garcia-Quiros requested to merge (removed):fix-modearray-GSimulation into master

Description

Hi @maria.haney,

When using the --modesList argument of GenerateSimulation I obtained several memory leaks problems and segmentation fault for any waveform model.

valgrind --leak-check=full --track-origins=yes /home/cecilio.garcia-quiros/lalsuite_master/build/lalsimulation/test/.libs/GenerateSimulation --domain FD --approximant IMRPhenomXHM --spin1z 0.6 --spin2z 0.5 --m1 40. --m2 20. --f-min 20. --f-max 1024. --deltaF 0.125 --inclination 1.043 --modesList "2,2, 2,-2"
...
==273546== 
==273546== For lists of detected and suppressed errors, rerun with: -s
==273546== ERROR SUMMARY: 16 errors from 16 contexts (suppressed: 0 from 0)
Segmentation fault

I changed the way the modes are read and now it works:

==1678937== For lists of detected and suppressed errors, rerun with: -s
==1678937== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

The reason we did not see this during the review is because GenerateSimulation was changed after the MR to fix the CI pipeline and the checks were not repeated with that change.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Edited by Cecilio Garcia-Quiros

Merge request reports