Skip to content

Add fabs to prevent negative Spl2 and Smi2

Geraint Pratten requested to merge waveforms/reviews/lalsuite:phenomxphm_patch into master

Description

This adds a small patch for IMRPhenomXP(HM) to catch a pathology resulting in NaNs that can occur when the in-plane spins are extremely small (~ numerical precision) leading to negative values of Smi2. Flagged up by @cecilio.garcia-quiros.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

A regression test has been performed with the corner plot here. Mismatches agree to ~ numerical precision. Output from regression test attached here.

Other notes:

  • Master branch corresponds to git commit 1016f628 (~ 5th Nov 2020) here:

1016f628

  • Fixed branch corresponds to git commit 73260889 (branched from current master ~ 13th Nov) here:

https://git.ligo.org/waveforms/reviews/lalsuite/-/tree/phenomxphm_patch

Edited by Maria Haney

Merge request reports