Skip to content

Fix overwriting of laldict in GetAndSetPrecessingVariables

Cecilio Garcia-Quiros requested to merge waveforms/reviews/lalsuite:fix-laldict-overwrite into master

Description

Hi @maria.haney,

This is a similar fix to that in !1451 (merged) but in that MR I missed the cases with high mass ratio for which we switch off the multibanding. This happens in the function GetAndSetPrecessingVariables. I just moved the "duplication" of the laldict to happen before the call to this function. I also incorporated the fix to XP.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Reviewed just by Cecilio.

Merge request reports