Skip to content

Choosefdmodes review

Cecilio Garcia-Quiros requested to merge waveforms/reviews/lalsuite:choosefdmodes-review into master

Description

Introduce a new interface in LALSimulation to obtain a set of spin-2 weighted spherical harmonics modes for binary black hole mergers for a given waveform approximant in the Fourier Domain. The currently supported approximants are the AS models IMRPhenomXHM, IMRPhenomHM and SEOBNRv4HM_ROM, and the precessing IMRPhenomXPHM.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

The review wiki can be found here The review team was formed by @jacob.lange and @riccardo-sturani as reviewers and @cecilio.garcia-quiros as reviewee The review conclusion will be presented at the 20201210 waveform call.

Merge request reports