Skip to content

XLALComputePSDandNormSFTPower(): add option normalizeSFTsInPlace

David Keitel requested to merge david-keitel/lalsuite:XLALComputePSDandNormSFTPower-add-option-normalizeSFTsInPlace into master

Description

Resolves #394 (closed) by making it possible to set this new option to false and reuse the original inputSFTs afterwards. For performance reasons, lalapps_ComputePSD will continue using the old behaviour, as the SFTs are not needed again in that application.

I've also improved the test script along the way.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

This is an API change, but the changed function is relatively new (only introduced in !1294 (merged)) and shouldn't have been used much outside of the two internal caller cases here. It's necessary for making the XLALComputePSDfromSFTs() wrapper function really useful to python end users, otherwise they always need to make manual copies of their SFT data to be safe from the original behaviour.

Review Status

@karl-wette please have a look but it's not urgent.

Merge request reports