Skip to content

Deprecate lalapps/src/lalapps/lalapps.[ch]

Karl Wette requested to merge (removed):deprecate-lalapps-h into master

Description

The purpose of this MR is to make it easier to potentially move programs from LALApps over to one of the library packages (e.g. LALPulsar), by reducing the dependencies of LALApps programs on LALApps-only code under lalapps/src/lalapps. Two files there which most LALApps programs depended on are lalapps/src/lalapps/lalapps.[ch]. The code in these files has been either deprecated or moved as described in #313 (closed) and as below:

  • const LALStatus blank_status: search-and-replace with XLAL_INIT_DECL()
  • error handlers LAL_ERR_EXIT, LAL_ERR_ABRT, LAL_ERR_RTRN, and error handler type lal_errhandler: move to lal/lib/std/LALError.[ch]
  • int clear_status( LALStatus * ): not used anywhere, can be deleted
  • char *XLALGetVersionString( int level ): replace with equivalent call to XLALVCSInfoString(); see lalapps/src/lalapps/lalapps.c for details
  • int XLALOutputVersionString ( FILE *fp, int level ): replace with equivalent call to XLALVCSInfoString(); see lalapps/src/lalapps/lalapps.c for details.
  • macro LAL_CALL() for calling LALStatus functions: move to lal/lib/std/LALError.h
  • macro PRINT_VERSION for printing CVS (!!) version info: replace with call to XLALVCSInfoString()

Inclusion of lalapps.h has been replaced with config.h and LALAppsVCSInfo.h.

LALApps programs still link against lalapps/src/lalapps/liblalapps.la, as that provides LALAppsVCSInfo.c and some other low-level frame-reading functions used by lalapps/src/inspiral/.

Closes #313 (closed)

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

N/A

Edited by Karl Wette

Merge request reports