Skip to content

lalapps_ComputeFstatistic_v2: disable use of resampling with non-factored grid types

Karl Wette requested to merge (removed):CFSv2-resamp-nonfac-grids into master

Description

Some of the template bank grid options to lalapps_ComputeFstatistic_v2 don't work with its (hacked) use of the resampling F-statistic:

  • Grid types 0=flat, 1=isotropic, 2=metric, 3=skygrid-file are "factored" grids where frequency, spindown, and sky parameters are independent of each other. These grid types should work with resampling.
  • Grid type 6=grid-file uses arbitrary frequencies from a file, and grid types 8=spin-square, and 9=spin-age-brk are a) non-factored grids (frequency and spindowns are not independent) and b) use their own frequency spacing given by the spindown metric. These grid types shouldn't really work with resampling.

This MR raises an error if resampling is used with grid types >= 6. (Strictly speaking, the grid type is compared against GRID_SKY_LAST, which is the end-marker for factored grid types.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

N/A

Edited by Karl Wette

Merge request reports