Skip to content

ensure test value is a REAL4

Adam Mercer requested to merge adam-mercer/lalsuite:fix-implicit-conversion into master

Description

When building under conda the following warning is encountered:

/Users/runner/miniforge3/conda-bld/lal-split_1611840399916/work/test/support/UserInputParseTest.c:162:17: error: implicit conversion from 'int' to 'REAL4' (aka 'float') changes value from 2147483647 to 2147483648 [-Werror,-Wimplicit-const-int-float-conversion]
  valREAL4Ref = 2147483647;
              ~ ^~~~~~~~~~

this is addressed by explicitly making varREAL4Ref a floating point number to avoid the implicit conversion.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Merge request reports