Skip to content

Allow DE435 solar system ephemeris and fix knope_utils segment generation

Matthew Pitkin requested to merge matthew-pitkin/lalsuite:o3pulsars into master

Description

A change has been added to lalapps_create_solar_system_ephemeris_python.py to allow it to generate Sun and Earth ephemeris files based on the DE435 JPL ephemerides. In knope_utils.py a change has been made to add DE435 as an allowed ephemeris system.

A further minor fix has been made in knope_utils.py, which corrects an indexing error. When creating science segments to use for analysis it allows certain DQ flags to be excluded. An index error in a for loop meant that only one exclusion criteria would be used, when really multiple exclusions should be allowed (this hasn't actually been an issue for any previous analysis, but is needed for the O3 analysis).

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

These changes are very minor @david-keitel @karl-wette

Merge request reports