LALSimulation: fix confusing PSD function names
I have been asked why PSD models available in LALSimulation from LIGO-P1800545 do not include Advanced Virgo. I reviewed the code, and found that those PSD model functions have the string
aLIGO mistakenly inserted in their name, even though they refer to non-LIGO detectors (see #428). Some LIGO PSD models also have the string repeated (
aLIGOaLIGO). Users apparently see the incorrect
aLIGO in the name, and assume the PSD refers to LIGO detectors. This request changes the names so that there is less confusion.
API Changes and Justification
Backwards Compatible Changes
- This change introduces no API changes
- This change adds new API calls
Backwards Incompatible Changes
- This change modifies an existing API
- This change removes an existing API
PSD function names were chosen incorrectly when they were first implemented.
If desired, I could add some preprocessor directives to still support the old names, but I have not done so yet.
No review has been made or requested.