Skip to content

Ensure CODEOWNERS has at least 3 maintainers per file

Karl Wette requested to merge (removed):at-least-3-codeowners into master

Description

@adam-mercer @duncanmmacleod To prevent bottlenecks in merge requests (e.g. !1565 (merged), !1577 (merged)) it would be good to have at least 3 maintainers per file.

I've had a go at modifying .gitlab/CODEOWNERS, starting with a whitespace/duplicate name clean-up, then adding the 3 of us as maintainers for all the infrastructure files. (For the record, I'd be more than happy to substitute my name if there's someone else who has more time for LALSuite maintenance.)

I also removed imene.belahcene as they are no longer in the LVK. Not sure whether all the other names are current.

There are some LAL packages / LALApps directories with only 2 maintainers. Here are some suggestions for an extra maintainer, where I can think of them:

  • lalpulsar/ : matthew-pitkin
  • lalapps/src/findchirp/ : ?
  • lalapps/src/frametools/ : ed-maros?
  • lalapps/src/hwinjection/ : matthew-pitkin
  • lalapps/src/lalapps/ : duncanmmacleod?
  • lalapps/src/power/ : ?
  • lalapps/src/pulsar/ : matthew-pitkin
  • lalapps/src/ring/ : ?

We should remember to add these people as Developers of lscsoft/lalsuite, if not members already

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

N/A

Merge request reports

Loading