Skip to content

MFDv5 / XLALCWMakeFakeData: fix SFT band selection when loading frames

David Keitel requested to merge david-keitel/lalsuite:MFDv5_fMin-Band-inFrames into master

Description

Fixes #432 (closed) - this combination of options has been marked as "FIXME" since the code exists, but if I haven't overlooked any side effects, it seems as simple as adding another call to XLALExtractBandFromSFTVector and removing some check conditions that are then no longer needed.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

@karl-wette this isn't really covered by the test suite. What I've tested manually: 1.

lalapps_Makefakedata_v5 --inFrames ./H1_frame_cache.lcf --inFrChannels H1:DCS-CALIB_STRAIN_GATED_SUB60HZ_C01 --fmin 17.0 --Band 683.0 --outSFTdir ./ --outSingleSFT False --startTime 1238112018 --duration 1800 --SFTWindowType tukey --SFTWindowBeta 0.001

with a single-frame cache file (O3 data) produces SFTs covering [0,8192]Hz with the original version and [17,700]Hz after the patch.

  1. content of the new output SFT is identical to the corresponding subband of the original broader SFTs

  2. Adding --outFrameDir and using lalfr-print on the result before/after the patch produces identical text files.

But I haven't really used frame I/O of MFD much, so please check if you can think of any side effects.

cc @patrick-meyers

Merge request reports