Skip to content

Add optional LALFrame dependency to LALPulsar

Karl Wette requested to merge (removed):lalpulsar-opt-depend-lalframe into master

Description

This MR adds an optional dependency on LALFrame to LALPulsar, using the Autoconf macro LALSUITE_CHECK_OPT_LIB().

The first patch is necessary to correctly re-configure the top-level build; otherwise, LALPulsar won't pick up the new LALFrame dependency.

The second patch adds the dependency, and updates the Conda/Debian/RPM packages.

The package lalpulsar/python/lalpulsar/simulateCW.py has an optional dependency on LALFrame, so this change is justified for existing code. The main purpose, however, is looking forward to eventually [1] moving CW programs in LALApps to LALPulsar. Since that will be a large change, I'd like to get some of the preliminary steps done first: in this case, getting the LALFrame dependency for LALPulsar in place, so that any packaging issues can be worked out during the next release.

[1] Not before all O3 CW analyses are done.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

I guess this isn't an API change?

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

cc @adam-mercer @duncanmmacleod @david-keitel

Merge request reports