Skip to content

Adding IMRPhenomTP/IMRPhenomTPHM waveform approximants

Hector Estelles requested to merge waveforms/reviews/lalsuite:phenomtphm-review into master

Description

This commit includes two new waveform approximants for quasi-circular precessing BBH systems:

  • IMRPhenomTP
  • IMRPhenomTPHM

These are phenomenological models in the time domain, extending the non-precessing NR calibrated models IMRPhenomT/THM to precession via the ``twisting up'' procedure.

This commit also includes some minor changes in the IMRPhenomX* family, mainly a regularisation for the MSA angles near the aligned-spin limit, and a change in the default values of PhenomXPrecVersion and PhenomXFinalSpinMod for accommodating the new default values for IMRPhenomTP and IMRPhenomTPHM.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Waveform review signed off by @maria.haney. Review statement: https://git.ligo.org/waveforms/reviews/phenomt/-/wikis/home#stage-2-review-sign-off-for-precessing-models

Edited by Hector Estelles

Merge request reports