Skip to content

Fixing spin contributions to orbital angular momentum in SpinTaylorTx precession equations

Riccardo Sturani requested to merge riccardo-sturani/lalsuite:fix_ls_master_rebase into master

Description

This branch introduces new features into the SpinTaylor precession equations:

  • it introduces a flag that can switch on spin dependent term in the orbital angular momentum
  • it introduces a flag that can switch between orbital-averaged and instantaneous phasing and precessing equations

API Changes and Justification

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

The new features required a rationalization of the "XLALSimInspiralSpinTaylorTxCoeffs" structure and the addition of an input variable in XLALSimInspiralSpinTaylorPNEvolveOrbit(). Note however that XLALSimInspiralSpinTaylorPNEvolveOrbit() is wrapped in a backward-compatible way by XLALSimInspiralSpinTaylorDriver() and XLALSimInspiralSpinTaylorOrbitalDriver() and the use of XLALSimInspiralSpinTaylorPNEvolveOrbit() as external function is discouraged and should be discontinued.

This merge request replace the old !1412 (closed)

Review Status

Review ongoing, see https://git.ligo.org/waveforms/reviews/lalsimulation.siminspiralspintaylorpnevolveorbit/-/wikis/home

Edited by Riccardo Sturani

Merge request reports