Skip to content

heterodyne_pulsar.c: exit with error if no data has been read in

Matthew Pitkin requested to merge matthew-pitkin/lalsuite:fail_with_no_data into master

Description

Currently the lalapps_heterodyne_pulsar code will not fail if no frame data was able to be read in during the coarse heterodyne stage. It will instead just create an empty output file, which will instead cause subsequent runs of lalapps_heterodyne_pulsar in fine heterodyned mode to fail. This MR changes this behaviour, so if no data is read in the code will exit with a return value of 1. This means that if the code is run as part of a Condor DAG it will detect the failure and add the coarse heterodyne job to any rescue DAG.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

cc @karl-wette @david-keitel

Merge request reports