Skip to content

Add WF error catching into LALInferenceROQWrapperForXLALSimInspiralChooseFDWaveformSequence

Carl-Johan Haster requested to merge cjhaster/lalsuite:Add_WFerror_Catching_to_ROQ_WFgenerator into master

Description

When using the ROQ likelihood function, and its associate LALInferenceROQWrapperForXLALSimInspiralChooseFDWaveformSequence waveform generator function there wasn't actually anything that would catch errors thrown by the waveform generator... So this MR adds in those checks (copyPasted from other WF functions in LALInferenceTemplate.c) into LALInferenceROQWrapperForXLALSimInspiralChooseFDWaveformSequence.

I've tested this implementation such that runs with WFs that throw errors are now able to proceed in their sampling after this MR has been applied, whereas the same runs with the old code crashed at the point of the first WF error.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

This MR doesn't use any new code, and should not trigger any distinct code review (apart from a general LALInference review, at the time such is deemed necessary).

Merge request reports