Fix all 'unused-{but-set-}variable' compiler errors
Description
This MR closes #450 (closed) and fixes a number of other unused-but-set-variable errors exposed by the clang:dev CI job. The intention is for no changes to any functional logic or API, and only to remove the unused variables, but my C foo isn't too strong so I probably messed something up.
- cc @jolien-creighton (lalframe)
- cc @ian-harry (lalinspiral and lalapps/coh_ptf)
- cc @karl-wette (lalpulsar)
- cc @john-veitch (lalinference)
API Changes and Justification
Backwards Compatible Changes
-
This change introduces no API changes -
This change adds new API calls
Backwards Incompatible Changes
-
This change modifies an existing API -
This change removes an existing API
If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.
Review Status
Please provide details on any reviews related to this change and and the associated reviewers.