Skip to content

Use int value for reference GPS nanoSeconds in LAL test, rather than conversion from float

Duncan Macleod requested to merge duncanmmacleod/lalsuite:fix-455 into master

Description

This MR closes #455 (closed) by modifying the failing test (test_MJDTT_GPS) to create the reference GPS time using a basic integer, rather than an on-the-fly float->int conversion, which exhibits precision errors when compiling with icc.

I don't understand the full implications of this change, or why 0.816 * 1e9 was chosen as the reference in the first place.

/cc @karl-wette @jolien-creighton @adam-mercer

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Merge request reports