Skip to content

Use higher precision for variable in LALInspiralSpinBank

Duncan Macleod requested to merge duncanmmacleod/lalsuite:lalinspiral-test-precision-issue into master

Description

This MR fixes a test failure exposed when using icc caused by a lack of precision when attempting to find the minimum of a PSD, as done in LALInspiralSpinBank. The fix is just to use REAL8 (double) instead of REAL4 (single) to store the value of the minimum. Since the incoming PSD is a REAL8FrequencySeries this probably should have been a REAL8 in the first place.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Merge request reports