Skip to content

thinca: allow negative event IDs

Kipp Cannon requested to merge (removed):thinca_negative_ids into master

Description

The inspiral coincidence code uses negative integers internally to signal error conditions. Recent upgrades to the gstlal pipeline related to the introduction of non-candidate templates have resulted in it making use of negative template IDs for safety checks. This patch modifies the error handling in thinca to allow negative template IDs to be passed through the code without being mistaken for error conditions.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

This patch has been used in test DAGs.

Merge request reports