Skip to content

Patch to XLALSimIMRPhenomXPMSAAngles and XLALSimIMRPhenomXPPNAngles. Add...

Geraint Pratten requested to merge geraint.pratten/lalsuite:phenomx_patch_aug_2021 into master

Description

This patch:

  • Fixes a memory leak due to an incorrect call to XLALDestroyDict in XLALSimIMRPhenomXPFrequencySequence.
  • Reduces the MSA errors from an XLAL_PRINT_ERROR to an XLAL_PRINT_WARNING. This will hopefully mitigate the overly bloated output found in PE.
  • Changes interface to XLALSimIMRPhenomXPMSAAngles and XLALSimIMRPhenomXPPNAngles so that you can specify f_min, f_max and the m-index directly. These are stand alone interfaces to the angles used in PhenomX and should not interfere with other functions. This would break backwards compatability but does allow the functions to be called in a more useful and general way. It also fixes a memory leak error in these functions due to an incorrect call to XLALDestroyDict.
  • Introduce a new interface to PhenomX, XLALSimIMRPhenomXPHMOneModeFrequencySequence that is just the FrequencySequence equivalent of XLALSimIMRPhenomXPHMOneMode.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Sanity check on the FrequencySequence documented here

Edited by Geraint Pratten

Merge request reports