Skip to content

Makefakedata_v5: promote randSeed and sourceDeltaT from developer to regular options

David Keitel requested to merge mfdv5-promote-dev-opts into master

Description

This promotes the two developer options of MFDv5 to regular options.

For --randseed I think it's a no-brainer; writing reproducible SFTs is a very common task for normal users, not just for developers.

For --sourceDeltaT I'm not familiar with the detailed history, but the comment about "previous internal defaults" really seems to imply that those are intended more as a fallback, and users should be aware that this option exists and they might want to set it differently in some cases. Also I had to dig around a bit to find where the defaults are actually set, it's here and I've added a mention of that function name to make it easier to discover.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@karl-wette please have a look and let me know what you think, especially for the second option.

Merge request reports