Skip to content

Draft: Remove unnecessary VCS/Build info makefile variables

Duncan Macleod requested to merge duncanmmacleod/lalsuite:cleanup-vcs-makefile into master

Description

This MR attemps to clean up some build infrastructure by removing variables that no longer serve any purpose:

  • vcs_build_info_source: this was defined only in order to declare prerequisites for it, but since in all cases the named file is generated by autoconf it will almost certainly predate everything else in the build by default, so this makes no sense (any more)
  • build_info_dependencies: this list defined prerequisites for the $(build_info_source) target, however that target is so simple that it doesn't make sense for it to depend on the existence of other files (any more)

In all this should have no visible impact on the build.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Edited by Duncan Macleod

Merge request reports