Skip to content

Draft:Seobnrv4hm nsbh

Michael Puerrer requested to merge michael.puerrer/lalsuite:seobnrv4hm-nsbh into master

Description

A multi-modal Fourier domain waveform model for neutron-star black hole binaries with aligned spins and tidal corrections. This model combines the BBH SEOBNRv4HM_ROM and SEOBNRv4_ROM_NRTidalv2_NSBH (22-mode) models to provide tidal amplitude and phase corrections for all modes. This is done by scaling the tidal NSBH amplitude and phase corrections which have been computed for the 22-mode and are used in the SEOBNRv4_ROM_NRTidalv2_NSBH model.

This model is expected to be useful and superior to the currently implemented NSBH models which neglect the effect of higher harmonics (IMRPhenomNSBH, SEOBNRv4_ROM_NRTidalv2_NSBH), when higher order modes and tidal effects matter for the source.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

This MR adds four new XLAL callable functions which implement the above waveform model. These functions provide either the modes or the waveform polarizations in the Fourier domain, and, either on a Nyquist grid or on a user-specified frequency grid.

  • XLALSimIMRSEOBNRv4HMROMNRTidal()
  • XLALSimIMRSEOBNRv4HMROMNRTidalFrequencySequence()
  • XLALSimIMRSEOBNRv4HMROMNSBH_Modes()
  • XLALSimIMRSEOBNRv4HMROMNSBHFrequencySequence_Modes()

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

The XLALSimIMRSEOBNRv4HMROMFrequencySequence_Modes function had a dependency on the inclination angle which was erroneously added and unused, I have removed the inclination argument since this dependence only comes in when computing the polarizations from the modes and is confusing.

The XLALSimIMRSEOBNRv4HMROMFrequencySequence_Modes is used for reduced order quadratures which have not yet been built.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

  • This will be filled in shortly once a review page and team is set up.
  • The draft tag will be removed once the review has been completed.

Merge request reports