Skip to content

.gitlab-ci.yml: check for build files not in .gitignore

Karl Wette requested to merge ANU-CGA/lalsuite:gitlab-ci-gitignore into master

Description

People sometimes forget to add build products to .gitignore (e.g. new executables in LALApps), which then show up in git status which building in the source directory. The CI should really check for this.

I've modified the .make-distcheck rule in .gitlab-ci.yml to do this. The rule first runs make all, then checks that git status is clean -- and will fail if not -- before running make distcheck. This rule will now build LALSuite twice; however since ccache is being used the extra time from the all build should be minimal. (When I made the build fail at the git status check, it has been running for ~10 minutes.) On the other hand, build errors might actually show up a bit sooner in a make all build, as opposed to make distcheck which has to first build a tarball, run ./configure, etc. So hopefully there's minimal impact from this change.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Merge request reports